feat(nextjs): Auto-wrap edge-routes and middleware #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
This was referenced Jan 12, 2023
lforst
force-pushed
the
lforst-edge-auto-wrapping
branch
from
760df35
to
c31d07f
Compare
lforst
force-pushed
the
lforst-edge-auto-wrapping
branch
from
1eb3183
to
416a7c8
Compare
AbhiPrasad
reviewed
Jan 16, 2023
| * This file is a template for the code which will be substituted when our webpack loader handles API files in the | ||
| * `pages/` directory. | ||
| * | ||
| * We use `__RESOURCE_PATH__` as a placeholder for the path to the file being wrapped. Because it's not a real package, | ||
| * We use `__SENTRY_WRAPPING_TARGET__` as a placeholder for the path to the file being wrapped. Because it's not a real package, |
There was a problem hiding this comment.
l: should we call this __SENTRY_WRAPPING_TARGET_FILE__ to be a little more clear?
| @@ -99,23 +99,61 @@ export function constructWebpackConfigFunction( | |||
|
|
|||
| if (isServer) { | |||
| if (userSentryOptions.autoInstrumentServerFunctions !== false) { | |||
| const pagesDir = newConfig.resolve?.alias?.['private-next-pages'] as string; | |||
There was a problem hiding this comment.
We looked at this really obscure field with a typecast here, and I am not sure if it is even part of the Next.js public API. Behavior around the pages and pages/src directory is pretty well defined here and it felt safer in the long run to just do the lookup ourselves. I guess it is not really required to be in this PR but snuck it in as a little cleanup.
AbhiPrasad
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #6120
Ref #4206
Based on #6771, this PR adds automatic wrapping of Edge routes and Next.js middleware.